Skip to content

Conversation

dns2utf8 and others added 30 commits August 4, 2016 12:06
This fixes rust/rust-lang#35245
…llaumeGomez

Comment on the casts in the `seek` implementations on files
…akis

Update the man page rustc.1

Should the page become a generated one so the version is allways up to date?
…mat, r=GuillaumeGomez

Update error message for E0166

Fixes rust-lang#35271 as part of rust-lang#35233.

r? @jonathandturner
Jonathan Turner added 15 commits August 5, 2016 14:54
…andturner

Update E0106 error message to new format.

This fixes rust-lang#35245, as part of the big error message update in rust-lang#35233

r? @jonathandturner
Update E0379 to new format rust-lang#35338

Fixes rust-lang#35338, as part of rust-lang#35233.

But this does not include the bonus. From my understanding a Span is defined by a `hi` and a `lo` position within some context. A naive way would be to mutate the span so that `hi` is 5 positions from `lo` which corresponds to the `const` keyword. But this methods feels a bit rigid. Is there another way to do this?

r? @jonathandturner
…t, r=jonathandturner

Updated E0306 to new format.

Part of rust-lang#35233.
Fixes rust-lang#35315.

r? @jonathandturner
…urner

Update E0229 to new format

Hello,

This fixes rust-lang#35305. I ran the tests, no unit test broke, even though some were ignored.

Cheers

r? @jonathandturner
@rust-highfive
Copy link
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 5, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 5, 2016

📌 Commit 9154cc9 has been approved by jonathandturner

@sophiajt
Copy link
Contributor Author

sophiajt commented Aug 5, 2016

@bors p=1

@bors
Copy link
Collaborator

bors commented Aug 6, 2016

⌛ Testing commit 9154cc9 with merge 43446fc...

bors added a commit that referenced this pull request Aug 6, 2016
@bors
Copy link
Collaborator

bors commented Aug 6, 2016

💔 Test failed - auto-win-gnu-32-opt-rustbuild

@sophiajt sophiajt closed this Aug 6, 2016
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.